GNOME Bugzilla – Bug 755108
mssdemux: playback always starts at lowest bitrate
Last modified: 2015-09-30 16:21:57 UTC
In gst_mss_demux_setup_streams() we attempt to configure the bitrate on not-yet-active streams so gst_mss_manifest_change_bitrate() has no effect. Instead I think we should first create the streams, activate them and then configure the bitrate. I'll send a patch.
Created attachment 311447 [details] [review] mssdemux: activate streams before configuring bitrate Doing the contrary has no effect and the consequence is that playback will start with the lowest bitrate even if we can already handle higher bitrate.
Created attachment 311448 [details] [review] mssdemux: activate streams before configuring bitrate Doing the contrary has no effect and the consequence is that playback will start with the lowest bitrate even if we can already handle higher bitrate.
Review of attachment 311448 [details] [review]: Good catch! (For the record, it seems to depend on the patch here https://bugzilla.gnome.org/review?bug=753613)
If neeed I can rebase the patch against current master. Thanks for the reviews Thiago :)
I'll rebase this one against git master this week.
Created attachment 312431 [details] [review] mssdemux: activate streams before configuring bitrate Doing the contrary has no effect and the consequence is that playback will start with the lowest bitrate even if we can already handle higher bitrate. Same patch but rebased on current git master.
commit bf1246cb1315caa48d7b9c2fd347206512a84a5f Author: Philippe Normand <philn@igalia.com> Date: Wed Sep 16 12:50:46 2015 +0200 mssdemux: activate streams before configuring bitrate Doing the contrary has no effect and the consequence is that playback will start with the lowest bitrate even if we can already handle higher bitrate. https://bugzilla.gnome.org/show_bug.cgi?id=755108