After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754997 - cerbero: add recipe for spandsp
cerbero: add recipe for spandsp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-14 13:39 UTC by George Kiagiadakis
Modified: 2015-10-04 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
recipes: add spandsp.recipe (968 bytes, patch)
2015-09-14 13:39 UTC, George Kiagiadakis
committed Details | Review

Description George Kiagiadakis 2015-09-14 13:39:41 UTC
Created attachment 311282 [details] [review]
recipes: add spandsp.recipe

Cerbero is missing a recipe for building spandsp, which is needed for building the spandsp plugin in gst-plugins-bad
Comment 1 Nicolas Dufresne (ndufresne) 2015-10-03 17:10:00 UTC
Attachment 311282 [details] pushed as 6f770b9 - recipes: add spandsp.recipe
Comment 2 Sebastian Dröge (slomo) 2015-10-03 17:16:51 UTC
Fails to build on Android: https://ci.gstreamer.net/job/cerbero-android-armv7/4029/console
Comment 3 Sebastian Dröge (slomo) 2015-10-03 17:17:05 UTC
Also all the other Android variants
Comment 4 Sebastian Dröge (slomo) 2015-10-03 17:17:51 UTC
And Windows: https://ci.gstreamer.net/job/cerbero-cross-mingw32/3059/console
Comment 5 Nicolas Dufresne (ndufresne) 2015-10-03 17:26:16 UTC
How could I know, I was also waiting for the build results.
Comment 6 Nicolas Dufresne (ndufresne) 2015-10-03 17:30:46 UTC
Please, wait for all the test results before reverting:

commit b98f0e6914fcd5b4209aad28e4e4844565dbfbf1
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Sat Oct 3 17:35:26 2015 +0100

    spandsp: Compile and package this plugin
    
    Compile and package spandsp plugin.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754997

(no need to revert the spandsp recipe patch). For Android (and cross compilation) we'll need:

  os.environ['ac_cv_func_malloc_0_nonnull'] ='yes'
  os.environ['ac_cv_func_realloc_0_nonnull'] ='yes'

It's a bug in autoconf
Comment 7 Sebastian Dröge (slomo) 2015-10-03 17:32:25 UTC
Sure, I was not going to revert it at this point, we're not going to release 1.7.1 tomorrow ;)
Comment 8 Sebastian Dröge (slomo) 2015-10-03 17:34:15 UTC
Also the Debian packaging fails, probably because spandsp:libs is not part of any .package: https://ci.gstreamer.net/job/cerbero-debian/4028/console

But you probably know that already :)
Comment 9 Nicolas Dufresne (ndufresne) 2015-10-03 18:08:21 UTC
Ok, this should make some progress already. Windows shall still fail, Olivier pointer to that:

http://stackoverflow.com/questions/10059200/how-do-i-fix-undefined-reference-to-imp

commit 98b2f6d036fc6705d6a075c38663f78b671082bc
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Sat Oct 3 18:50:46 2015 +0100

    spandsp: Also package it
    
    This is needed to generate correct packages. Fortunatly the debian
    packager complains, otherwise we just have packages with missing
    files.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754997

commit 9bb909e54f63cbf328fed998d999d4a1eb29bbde
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Sat Oct 3 18:49:46 2015 +0100

    spandsp: Skip two autoconf check when cross-compiling
    
    In cross-compilation, some autoconf check failed when they should
    not which lead to link error.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754997
Comment 10 Sebastian Dröge (slomo) 2015-10-03 18:14:35 UTC
Is someone going to work on fixing it for Windows?
Comment 11 Nicolas Dufresne (ndufresne) 2015-10-03 19:08:40 UTC
And still waiting for the builder to catchup, this one should help too:

commit b5ba15b218bce8587de29fd33b713400f427a1f2
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Sat Oct 3 20:06:06 2015 +0100

    spandsp: Fix build with mingw
    
    This is a specific fix, an upstream solution would be nicer eventually.
    We basically properly select the naming convention and ensure we use the
    stdcall convention for gethostname.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754997
Comment 12 Nicolas Dufresne (ndufresne) 2015-10-03 21:45:45 UTC
commit 851b094c061137c79f243f7bf9e5d80cdbc09bdb
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Sat Oct 3 22:42:36 2015 +0100

    spandsp: Always skip ac_cv_func_ check for Android
    
    This should fix a non-cross compiling case, Android x86_54 where
    this check was failing.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754997

commit 5d6929c7c8258aec95fd214a3c241ed8ba14b755
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Sat Oct 3 22:35:01 2015 +0100

    spandsp: Set empty patches array
    
    By not setting an empty patches array, we endup with the patches
    being randomly applied to other recipies.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754997
Comment 13 Edward Hervey 2015-10-04 08:24:01 UTC
It's also failing for cerbero/fedora builds : https://ci.gstreamer.net/job/cerbero-fedora/3450/console
Comment 14 Nicolas Dufresne (ndufresne) 2015-10-04 09:13:28 UTC
(In reply to Edward Hervey from comment #13)
> It's also failing for cerbero/fedora builds :
> https://ci.gstreamer.net/job/cerbero-fedora/3450/console

That fully works locally (F22), with none of the other "File not found" error we see with cpio in that trace. Is it possible to check if there isn't some disk space issue there, and maybe a wipe ?
Comment 15 Sebastian Dröge (slomo) 2015-10-04 16:56:20 UTC
All good now