GNOME Bugzilla – Bug 754962
[PATCH] Add custom directory files
Last modified: 2015-09-14 14:24:19 UTC
Created attachment 311232 [details] [review] Add custom directory files Settings.directory and Settings-System.directory are removed from gnome-menus: https://git.gnome.org/browse/gnome-menus/commit/?id=b68bcd27f44ce2c494f6e3cd9695890b9c02af04 Note that currently session and directory files are not detected properly, when I run 'make gnome-flashback.pot-update', so they left untranslated, and I don't know how to fix it: /usr/bin/xgettext: warning: file 'data/gnome-flashback-compiz.session.in' extension 'session' is unknown; will try C /usr/bin/xgettext: warning: file 'data/gnome-flashback-metacity.session.in' extension 'session' is unknown; will try C /usr/bin/xgettext: warning: file 'data/X-GNOME-Flashback-Settings.directory.in' extension 'directory' is unknown; will try C /usr/bin/xgettext: warning: file 'data/X-GNOME-Flashback-Settings-System.directory.in' extension 'directory' is unknown; will try C
Why these directory files are needed? I think that can be fixed by changing *.session.in to *session.desktop.in and *.directory.in to *directory.desktop.in.
> Why these directory files are needed? Without these directory files, we can't set an icon, and the name cannot be translated. > I think that can be fixed by changing *.session.in to *session.desktop.in > and *.directory.in to *directory.desktop.in. Yes, renaming the files solves the problem probably.
Ok. Can you update patch? And maybe create another to rename session files?
Created attachment 311239 [details] [review] Add custom directory files v2 Updated patch, now the file format is detected properly by xgettext.
Created attachment 311240 [details] [review] Rename session.in files After that xgettext will detect the correct file format, and makes the files translatable.
After the second patch, some random text added to the end of RequiredComponents line, but I have no idea, why. It breaks login, so don't apply it yet.
I have no idea what is the problem with the second patch, it truncates the RequiredComponents line, but it's not really needed, because session files are translated anyway somehow. So please apply the first patch, and ignore the second patch.
(In reply to György Balló from comment #6) > After the second patch, some random text added to the end of > RequiredComponents line, but I have no idea, why. It breaks login, so don't > apply it yet. It works for me. What gettext version do you have?
> What gettext version do you have? I'm using gettext 0.19.5.1, and it simply truncates the RequiredComponents line after 100 characters after my second patch.
(In reply to György Balló from comment #9) > > What gettext version do you have? > > I'm using gettext 0.19.5.1, and it simply truncates the RequiredComponents > line after 100 characters after my second patch. Do we need .session files translated? Is that visible to user?
> Do we need .session files translated? Is that visible to user? I think it's not visible anywhere, these session files are just used internally by gnome-session. The session name is available in the corresponding desktop files, which are used by display managers.
I pushed your patch with updated commit message. Thanks!