GNOME Bugzilla – Bug 754956
Missing Empathy status icon
Last modified: 2017-02-14 01:13:01 UTC
Currently, Empathy detects GNOME Flashback as GNOME Shell because "org.gnome.Shell" D-Bus name is available: https://git.gnome.org/browse/empathy/tree/src/empathy.c#n250 This causes the following problems: 1. Status icon is missing. 2. Auto-away feature is disabled. 3. No logout on exit. Empathy should be able to detect properly if it's really run under GNOME Shell.
Created attachment 311546 [details] [review] empathy: don't detect GNOME Flashback as GNOME Shell Under GNOME Flashback we are forced to use org.gnome.Shell dbus name. So if Empathy is used in GNOME Flashback it does not work correctly. When shell is detected run extra check to make sure that Empathy is used under real GNOME Shell.
I don't use Empathy, please test patch to make sure it really works.
I tested the patch. Yes, it works as expected in GNOME Flashback, and remains the same in GNOME Shell. Thanks!
Review of attachment 311546 [details] [review]: I think you can use g_strv_contains to simplify this: if (g_strv_contains (names, GNOME_SHELL_BUS_NAME) && !g_strv_contains (names, GNOME_FLASHBACK_BUS_NAME)) { self->shell_running = TRUE; }
Created attachment 332104 [details] [review] empathy: don't detect GNOME Flashback as GNOME Shell
Is there any progress? Could you please commit this patch?
Note that g_strv_contains is not available before glib2 2.44, so the requirements need to be adjusted if you apply the second version of patch (together with fixing some deprecations).
Created attachment 345686 [details] [review] empathy: don't detect GNOME Flashback as GNOME Shell Here is an updated patch with adjusted requirements. It builds fine now.
Attachment 345686 [details] pushed as 1eabf36 - empathy: don't detect GNOME Flashback as GNOME Shell