After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754927 - Non-void function should return a value
Non-void function should return a value
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2015-09-12 17:00 UTC by Ting-Wei Lan
Modified: 2015-09-12 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ting-Wei Lan 2015-09-12 17:00:58 UTC 
Function gimp_dnd_data_source_remove in app/widgets/gimpdnd.c has a return value, so it cannot use 'return;'. It should use 'return FALSE;'.
Comment 1 Michael Natterer 2015-09-12 18:29:54 UTC 
Oops, thanks! Fixed in master and gimp-2-8:

commit 9d5fed6ea66dba308400ce2f275b51d6d145d404
Author: Michael Natterer <mitch@gimp.org>
Date:   Sat Sep 12 20:26:56 2015 +0200

    Bug 754927 - Non-void function should return a value
    
    Fix return value glitch in last DND-related commit.
    
    (cherry picked from commit 1833d292cc5a30527c730d9328b4d6e41cf7fde5)

 app/widgets/gimpdnd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)