After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754785 - Let renames on Google Drive be undone
Let renames on Google Drive be undone
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.17.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 739008
 
 
Reported: 2015-09-09 15:12 UTC by Debarshi Ray
Modified: 2015-09-10 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
file, file-undo-operations: Let renames on Google Drive be undone (5.95 KB, patch)
2015-09-09 15:25 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2015-09-09 15:12:27 UTC 
As explained in bug 740383 ...

(i) Renaming a Google Drive file might not change the URI because the URIs can be made up of immutable IDs. Only the standard::display-name is guaranteed to change.

(ii) The standard::names are not fit to be shown in the UI. We should stick to standard::display-name.

Currently, NautilusFileUndoInfoRename tracks the old and new GFile objects, but those might have the same URI. Therefore, once the file has been renamed we won't get the old display name from the GFile. Also, it is using g_file_get_basename to get the display name which is wrong.

So let's extend NautilusFileUndoInfoRename to track the old and new display names as well as the actual GFile objects.
Comment 1 Debarshi Ray 2015-09-09 15:25:42 UTC 
Created attachment 311002 [details] [review]
file, file-undo-operations: Let renames on Google Drive be undone
Comment 2 Carlos Soriano 2015-09-10 07:33:19 UTC 
Review of attachment 311002 [details] [review]:

LGTM
Comment 3 Debarshi Ray 2015-09-10 10:22:37 UTC 
Comment on attachment 311002 [details] [review]
file, file-undo-operations: Let renames on Google Drive be undone

Thanks for the review, Carlos. I have pushed it to master.