After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754621 - Missing include in src/wayland/meta-xwayland-selection.c
Missing include in src/wayland/meta-xwayland-selection.c
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-05 23:48 UTC by Javier Jardón (IRC: jjardon)
Modified: 2015-09-07 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add missing include (791 bytes, patch)
2015-09-05 23:48 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
xwayland: Add missing include (812 bytes, patch)
2015-09-06 12:23 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2015-09-05 23:48:30 UTC 
Created attachment 310728 [details] [review]
Add missing include

This is the compilation error:

  CC       wayland/meta-wayland-pointer-gesture-pinch.lo
wayland/meta-xwayland-selection.c: In function 'meta_xwayland_selection_handle_xfixes_selection_notify':
wayland/meta-xwayland-selection.c:1363:3: error: unknown type name 'XFixesSelectionNotifyEvent'
   XFixesSelectionNotifyEvent *event = (XFixesSelectionNotifyEvent *) xevent;
   ^
wayland/meta-xwayland-selection.c:1363:40: error: 'XFixesSelectionNotifyEvent' undeclared (first use in this function)
   XFixesSelectionNotifyEvent *event = (XFixesSelectionNotifyEvent *) xevent;
                                        ^
wayland/meta-xwayland-selection.c:1363:40: note: each undeclared identifier is reported only once for each function it appears in
wayland/meta-xwayland-selection.c:1363:68: error: expected expression before ')' token
   XFixesSelectionNotifyEvent *event = (XFixesSelectionNotifyEvent *) xevent;
                                                                    ^
Comment 1 Jonas Ådahl 2015-09-06 04:07:41 UTC 
Review of attachment 310728 [details] [review]:

Looks good to me.
Comment 2 Jonas Ådahl 2015-09-06 04:09:41 UTC 
Review of attachment 310728 [details] [review]:

The only comment I have is missing bugzilla address in the commit body, and the commit subject should probably be "xwayland: Add missing include" or something short like that.
Comment 3 Javier Jardón (IRC: jjardon) 2015-09-06 12:23:22 UTC 
Created attachment 310747 [details] [review]
xwayland: Add missing include
Comment 4 Jonas Ådahl 2015-09-07 12:56:41 UTC 
Review of attachment 310747 [details] [review]:

Looks good to me.
Comment 5 Javier Jardón (IRC: jjardon) 2015-09-07 13:15:23 UTC 
Review of attachment 310747 [details] [review]:

commit 6ea7fa99736373b1a4ca8d089c5f214650cd4e3c

Thanks for the review