Created attachment 310676 [details] [review]
theme: Use font-relative sizes for menu widths

For menus, it makes more sense to pick a width that fits a reasonable amount
of content rather than a fixed amount of screen estate, so use font-relative
sizes instead of pixel values.

If you've put ui-review on this bug in the hope that I'll spend my time testing patches, then I'm going to have to disappoint you: it's not going to happen.

(In reply to Allan Day from comment #2)
> If you've put ui-review on this bug in the hope that I'll spend my time
> testing patches

I'd like to think that spending time writing explanatory commit messages like in comment #1 would actually make it possible to comment on an issue without fiddling around with code, but maybe not :-(

Review of attachment 310676 [details] [review]:

Looks good to me and definitely makes sense.
Needs to be rebased because of the change from bug 708472 though.

Review of attachment 310676 [details] [review]:

Oh and you shouldn't patch the css directly but the sass files instead otherwise your changes will get lost once someone regenerates the css from sass.

(In reply to drago01 from comment #5)
> Oh and you shouldn't patch the css directly but the sass files instead

Yes, but that works poorly with git-bz, so I attached the patch with the generated CSS. The actual patch is against gnome-shell-sass of course ...

(In reply to Florian Müllner from comment #3)
> (In reply to Allan Day from comment #2)
> > If you've put ui-review on this bug in the hope that I'll spend my time
> > testing patches
> 
> I'd like to think that spending time writing explanatory commit messages
> like in comment #1 would actually make it possible to comment on an issue
> without fiddling around with code, but maybe not :-(

It seems like an obvious improvement. I didn't think that you'd need my review for this!

Attachment 310676 [details] pushed as f8cc8f1 - theme: Use font-relative sizes for menu widths