GNOME Bugzilla – Bug 754576
compositor: input stream is wrongly considered obscured in some cases (regression)
Last modified: 2015-09-04 21:58:20 UTC
Since: > commit 9b59bb8630c8574da2a3b0db9c5cc530e7daa535 > Author: Nirbheek Chauhan <nirbheek@centricular.com> > Date: Wed Aug 26 15:40:16 2015 +0530 > compositor: Actually use the output resolution for clamping > The obscured check in compositor was using the dimensions of the pad to clamp > the h/w of the pad instead of the output resolution, and was doing an incorrect > calculation to do so. Fix that by simplifying the whole calculation by using > corner coordinates. Also add a test for this bug which fell through the cracks, > and just skip all the obscured tests if the pad's alpha is 0.0. > https://bugzilla.gnome.org/show_bug.cgi?id=754107 that pipeline: $ gst-launch-1.0 uridecodebin uri=file://$HOME/gst-validate/gst-integration-testsuites/medias/defaults/matroska/numerated_frames_blue.mkv ! compositor sink_0::xpos=-1 ! video/x-raw,height=240,width=319 ! autovideosink Outputs a 'checker' instead of outputing the frame with a x-position=-1
Created attachment 310681 [details] [review] compositor: Ensure all arguments to CLAMP are signed int See commit message for explanation. Moral of the story: don't mix differing integer types in comparisons (or any multi-argument operands).
Attachment 310681 [details] pushed as cf786a9 - compositor: Ensure all arguments to CLAMP are signed int
Thanks @nirbheek