GNOME Bugzilla – Bug 754528
decklinkvideosink: Properly handle pipelines where the running time does not start around 0
Last modified: 2015-09-09 14:01:36 UTC
See commit message
Created attachment 310592 [details] [review] decklinkvideosink: Handle pipelines where the running time does not start around 0 properly We were converting all times to our internal running times, that is the time the sink itself spent in PLAYING already. But forgot to do that for the running time calculated from the buffer timestamps. As such, all buffers were scheduled much later if the pipeline's running time did not start at 0. This happens for example if a base time is explicitly set on the pipeline.
About the commit message, does it say that a pipeline the does not start at running time 0 is not proper, or more something like "Properly handle the case where initial running is not 0" ?
The second case :) Starting at a running time that is not 0 is not a problem, just that the decklink synchronization code did not handle that.
Review of attachment 310592 [details] [review]: Looks correct to me (can't test).
Comment on attachment 310592 [details] [review] decklinkvideosink: Handle pipelines where the running time does not start around 0 properly Let's get this in then, I assume you've tested it.
commit b6498c32f3971bffbc4424353264932e7c47a7fc Author: Sebastian Dröge <sebastian@centricular.com> Date: Thu Sep 3 16:36:57 2015 +0300 decklinkvideosink: Handle pipelines where the running time does not start around 0 properly We were converting all times to our internal running times, that is the time the sink itself spent in PLAYING already. But forgot to do that for the running time calculated from the buffer timestamps. As such, all buffers were scheduled much later if the pipeline's running time did not start at 0. This happens for example if a base time is explicitly set on the pipeline. https://bugzilla.gnome.org/show_bug.cgi?id=754528