GNOME Bugzilla – Bug 754419
"Connecting to '%s'" shown in collection views
Last modified: 2016-09-20 08:15:55 UTC
Unifying 'status' of machines caused some issues and the one that's not yet resolved is us showing "Connecting to '%s'" and "Restoring '%s'" in collection views, where it doesn't completely fit in the available space usually and also it looks odd given that name of the machine is already shown in the context and is clear to user. We either need to modify these strings somehow or ensure that these status messages don't get shown in collection views.
Created attachment 310535 [details] Restore status label in topbar where it was original meant to be
Created attachment 310536 [details] Restore status label under the thumbnail (here is where it looks odd)
Created attachment 310537 [details] Same thing, just in list view
Created attachment 311308 [details] [review] machine: Don't show name in status The status is also shown now in listview and showing the name of the machine is not only redundant in that view but also looks ugly. Let's add the name where and when it's needed.
Created attachment 311421 [details] [review] machine: Set launch status directly to topbar The launch status strings are only useful for topbar. Moreover, the way they currently are, they look ugly in collection views and don't even fit in the space available. So let's just set these labels directly on the topbar, instead of going through Machine.status property.
Created attachment 311422 [details] [review] machine: Only bind name to Topbar.status if current Just cause the UI state is DISPLAY, doesn't mean every machine should bind it's name to topbar status. Only current machine should do that.
Created attachment 311423 [details] [review] machine: Bind name directly to topbar status The name has nothing to do with status anyway and going through Machine.status property makes it appear in collection views as well and that is just redundant and looks wrong and ugly. So let's just bind the name directly to the topbar status.
Attachment 311421 [details] pushed as 1cf5647 - machine: Set launch status directly to topbar Attachment 311422 [details] pushed as 437f1fa - machine: Only bind name to Topbar.status if current Attachment 311423 [details] pushed as b194ac3 - machine: Bind name directly to topbar status