After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754285 - compositor: add unit test for ensuring that sinkpads are sorted by zorder
compositor: add unit test for ensuring that sinkpads are sorted by zorder
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-29 13:48 UTC by Nirbheek Chauhan
Modified: 2015-09-26 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check: Add test for videoaggregator sinkpads being sorted by zorder (2.78 KB, patch)
2015-08-29 13:48 UTC, Nirbheek Chauhan 		committed Details | Review

Description Nirbheek Chauhan 2015-08-29 13:48:20 UTC 
The GST_ELEMENT(videaggregator)->sinkpads GList is supposed to always be sorted by zorder. A bunch of code in compositor relies on this (see f.ex bug 754229), but there's no test for it, and it's possible for someone to change/break this implied assumption by mistake.

The attached patch adds a test for this to compositor.
Comment 1 Nirbheek Chauhan 2015-08-29 13:48:55 UTC 
Created attachment 310257 [details] [review]
check: Add test for videoaggregator sinkpads being sorted by zorder
Comment 2 Tim-Philipp Müller 2015-09-26 09:34:21 UTC 
commit 7baa2736d9d5789aee76c86a819bc4e0994a881f
Author: Nirbheek Chauhan <nirbheek@centricular.com>
Date:   Sat Aug 29 19:16:38 2015 +0530

    check: Add test for videoaggregator sinkpads being sorted by zorder
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754285