After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754193 - harness: misc bugfixes
harness: misc bugfixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal critical
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 754196 754223
 
 
Reported: 2015-08-27 18:16 UTC by Håvard Graff (hgr)
Modified: 2015-08-31 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.36 KB, patch)
2015-08-27 18:16 UTC, Håvard Graff (hgr) 		none Details | Review
patch (2.75 KB, patch)
2015-08-29 18:19 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2015-08-27 18:16:01 UTC 
Created attachment 310112 [details] [review]
patch

1. Get a list of pad templates from the element class, not the factory.
This allows us to interact with test-elements that does not have
   a factory.

2. Use the pad_template_caps in caps-queries when caps is not set
   explicitly on the pad.
Not doing so is simply wrong, and prohibits interactions with special
templates used for testing
Comment 1 Håvard Graff (hgr) 2015-08-29 18:19:48 UTC 
Created attachment 310277 [details] [review]
patch

Was casting the pad_template_list to GstStaticPadTemplate instead of GstPadTemplate, which worked in some cases but not in others...
Comment 2 Tim-Philipp Müller 2015-08-31 11:05:42 UTC 
commit b2ce23074e5bd076573ca8c7e254e3080f5b75bc
Author: Havard Graff <havard.graff@gmail.com>
Date:   Sat Aug 29 20:14:44 2015 +0200

    harness: misc bugfixes
    
    1. Get a list of pad templates from the element class, not the
    factory. This allows us to interact with test-elements that does
    not have a factory.
    
    2. Use the pad_template_caps in caps-queries when caps is not set
    explicitly on the pad. Not doing so is simply wrong, and prohibits
    interactions with special templates used for testing.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754193