After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754183 - rtpbuffer: avoid internal ensure_buffers() when setting extension data
rtpbuffer: avoid internal ensure_buffers() when setting extension data
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.5.2
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-27 15:46 UTC by Miguel París Díaz
Modified: 2016-11-23 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpbuffer: avoid ensure buffers when setting extension data (2.06 KB, patch)
2015-08-27 15:46 UTC, Miguel París Díaz 		none Details | Review
Ensuring buffers Callgrind graph (80.36 KB, image/png)
2015-08-27 15:49 UTC, Miguel París Díaz 		  Details
NO ensuring buffers Callgrind graph (74.02 KB, image/png)
2015-08-27 15:50 UTC, Miguel París Díaz 		  Details

Description Miguel París Díaz 2015-08-27 15:46:30 UTC 
Created attachment 310102 [details] [review]
rtpbuffer: avoid ensure buffers when setting extension data

gst_rtp_buffer_set_extension_data function is supposed to be called after
mapping the GstRTPBuffer, so we can avoid ensure buffers which supposes too cost.
Instruction per call:
  Ensuring buffers: 4237
  Without ensuring buffers: 864
  Improvement: 1 - 864/4237 = 0.796

Callgrind graphs are also attached.
Comment 1 Miguel París Díaz 2015-08-27 15:49:36 UTC 
Created attachment 310103 [details]
Ensuring buffers Callgrind graph
Comment 2 Miguel París Díaz 2015-08-27 15:50:06 UTC 
Created attachment 310104 [details]
NO ensuring buffers Callgrind graph
Comment 3 Miguel París Díaz 2016-11-23 19:20:07 UTC 
Closed in favor of https://bugzilla.gnome.org/show_bug.cgi?id=774959