After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754144 - level: regression for channels > 1
level: regression for channels > 1
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Linux
: Normal blocker
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-26 21:33 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2015-08-31 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix block advance (843 bytes, patch)
2015-08-26 21:33 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2015-08-26 21:33:27 UTC 
Created attachment 310064 [details] [review]
fix block advance

After processing a block we only advance by block*bps, instead of block*bps*channels. This causes bad results for audio with channels>1.

This was broken with 7b90bf32150897a141a29a12ecab555d8c5b7fab.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2015-08-31 07:11:19 UTC 
FYI: I also have a patch for the unit-tests. Will push that once git is open again.
Comment 2 Sebastian Dröge (slomo) 2015-08-31 07:42:04 UTC 
Stefan, get it in now :)
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2015-08-31 11:58:11 UTC 
commit 22443b2eed18557dab14fa4fc2abb5e6710d590b
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Mon Aug 31 13:56:04 2015 +0200

    level: improve the test for multi-channel mode
    
    Change the test to verify the read-index for multiple messages per buffer.
    See https://bugzilla.gnome.org/show_bug.cgi?id=754144