After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753965 - [review] lr/multiple-vpn: openvpn plugin: add --bus-name argument
[review] lr/multiple-vpn: openvpn plugin: add --bus-name argument
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-08-22 15:07 UTC by Lubomir Rintel
Modified: 2015-11-05 11:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lubomir Rintel 2015-08-22 15:07:26 UTC 
Add --bus-name so that multiple instances can be spawned + some minor fixes for things that broke while testing this:

a0172ca service: ensure the service is disconnected when doing a new connection
3dcdfdd trivial: move real_disconnect() and ensure_killed() up
0ce1e7e service: add missing error handling
52d635a service: add --bus-name argument
b7c82d2 service: allow acquiring any names below org.freedesktop.NetworkManager.openvpn
570557c helper: add --bus-name argument
42411e8 all: rename some defines
Comment 1 Lubomir Rintel 2015-08-22 15:12:27 UTC 
https://git.gnome.org/browse/network-manager-openvpn/log/?h=lr/multiple-vpn

The daemon part is reviewed here: bug #753966
Comment 2 Lubomir Rintel 2015-10-13 18:02:02 UTC 
The daemon part now in

https://git.gnome.org/browse/network-manager-openvpn/log/?h=lr/multiple-vpn
Comment 3 Thomas Haller 2015-11-03 11:11:23 UTC 
>> service: drop use of API that's gone
>> service: ensure the service is disconnected when doing a new connection
   
the second commit just reworks the previous commit. Maybe merge them together and improve the commit message?


 

Other then that, LGTM.
Comment 4 Lubomir Rintel 2015-11-05 11:22:37 UTC 
c6b7293 merge: branch 'lr/multiple-vpn'
3ea0104 service: ensure the service is disconnected when doing a new connection
c99a39b trivial: move real_disconnect() and ensure_killed() up
b1944df service: add missing error handling
aced3d2 service: add --bus-name argument
d62b04c service: allow acquiring any names below org.freedesktop.NetworkManager.openvpn
1d3bcc5 helper: add --bus-name argument
4d84c9c all: rename some defines