After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753937 - dashdemux: don't meddle with the class struct from an instance
dashdemux: don't meddle with the class struct from an instance
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-21 15:24 UTC by Tim-Philipp Müller
Modified: 2015-08-28 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dashdemux: don't meddle with the class struct from an instance (2.95 KB, patch)
2015-08-21 15:24 UTC, Tim-Philipp Müller 		committed Details | Review

Description Tim-Philipp Müller 2015-08-21 15:24:55 UTC 
Created attachment 309823 [details] [review]
dashdemux: don't meddle with the class struct from an instance

Found some dubious code in dashdemux.
Comment 1 Tim-Philipp Müller 2015-08-26 23:39:31 UTC 
commit ef7f5fc4c7f19c35238cbdaa597cf43c90454e23
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Fri Aug 21 16:13:43 2015 +0100

    dashdemux: don't meddle with the class struct from an instance
    
    Fix some very dubious code. The class methods should always
    be set, and the instance-specific check should then be done
    inside the method. For data_received that's there already, for
    finish_fragment we need to add it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753937