After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753912 - rtspsrc: fix check if DESCRIBE method is supported
rtspsrc: fix check if DESCRIBE method is supported
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-21 07:29 UTC by Vineeth
Modified: 2015-08-28 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to check correct condition (890 bytes, patch)
2015-08-21 07:29 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-08-21 07:29:10 UTC 
When checking for describe method, because of missing parentheses, wrong condition is being checked, which will result in wrong behavior.
Comment 1 Vineeth 2015-08-21 07:29:57 UTC 
Created attachment 309789 [details] [review]
patch to check correct condition
Comment 2 Sebastian Dröge (slomo) 2015-08-21 08:07:32 UTC 
This was already caught at an earlier place in the code btw


commit ba8cda54f4de27817e9e5460c6a48e24b9012f41
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Fri Aug 21 16:29:16 2015 +0900

    rtspsrc: Trivial fix to check correct condition
    
    When checking for describe method, because of missing parentheses, wrong
    condition is being checked, which will result in wrong behavior.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753912
Comment 3 Tim-Philipp Müller 2015-08-21 08:32:39 UTC 
This would have been a more informative commit summary line:

 rtspsrc: fix check if DESCRIBE method is supported

Your summary line is basically just a very long version of 'rtspsrc: fix something' - imagine looking at a commit log where every message was like that :)