GNOME Bugzilla – Bug 753885
opencv: use gst_opencv_video_filter_set_in_place()
Last modified: 2015-09-29 19:47:33 UTC
Created attachment 309743 [details] [review] patch Using the gst_base_transform function directly won't work. Need to use gst_opencv_video_filter_set_in_place()
Created attachment 309744 [details] [review] patch for cvdilate In gstcvdilateerode.c transform is set to be done in place for cvdilate and cverode. Removing the non-in-place transform function in cvdilate because it is never used. Alternaviley, I could add "in-place" as a property of the element and the user could decide if he wants to do the transformation in place or not. In place saves memory but with two buffers it processes frames faster.
Created attachment 309747 [details] [review] patch for cverode Same as above for cverode.
Review of attachment 309743 [details] [review]: commit 45d9184c88bb5fcc250b0832f7e706afdff90d50 Author: Luis de Bethencourt <luisbg@osg.samsung.com> Date: Tue Sep 29 20:00:02 2015 +0100 opencv: use gst_opencv_video_filter_set_in_place() Using the gst_base_transform function directly won't work. Need to use gst_opencv_video_filter_set_in_place().
Review of attachment 309744 [details] [review]: commit 97ee5abd49cf211b0f682a77c250b612d7dcdb4f Author: Luis de Bethencourt <luis@debethencourt.com> Date: Thu Aug 20 17:23:40 2015 +0100 opencv: dilate: remove non-ip transform func Transform is set to be done in place in gstcvdilateerode.c, so the in-place transform function is always used and the other is redundant. Removing it. https://bugzilla.gnome.org/show_bug.cgi?id=753885
Review of attachment 309747 [details] [review]: commit 28b2ac7e65274fd99c017f54c6d7a239bead7901 Author: Luis de Bethencourt <luisbg@osg.samsung.com> Date: Thu Aug 20 17:35:04 2015 +0100 opencv: erode: remove non-ip transform func Transform is set to be done in place in gstcvdilateerode.c, so the in-place transform function is always used and the other is redundant. Removing it. https://bugzilla.gnome.org/show_bug.cgi?id=753885