After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753855 - wayland/pointer-gestures: Send error on protocol version mismatch
wayland/pointer-gestures: Send error on protocol version mismatch
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-20 03:50 UTC by Jonas Ådahl
Modified: 2015-08-21 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland/pointer-gestures: Send error on protocol version mismatch (2.82 KB, patch)
2015-08-20 03:50 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2015-08-20 03:50:28 UTC 
When a client binds an incompatible version, we should terminate it.
This check should only be there for the unstable version, as once it is
declared stable and renamed, future versions will be backward compatible.
Comment 1 Jonas Ådahl 2015-08-20 03:50:34 UTC 
Created attachment 309665 [details] [review]
wayland/pointer-gestures: Send error on protocol version mismatch
Comment 2 Carlos Garnacho 2015-08-21 16:01:12 UTC 
Comment on attachment 309665 [details] [review]
wayland/pointer-gestures: Send error on protocol version mismatch

Looks good to me! It seems fine as a fool-proof check. As agreed on irc we might consider relaxing if future protocol changes turn out to be compatible.
Comment 3 Jonas Ådahl 2015-08-21 16:05:25 UTC 
Attachment 309665 [details] pushed as e76c3ec - wayland/pointer-gestures: Send error on protocol version mismatch