GNOME Bugzilla – Bug 753852
gstreamer: base: Fix memory leaks when context parse fails.
Last modified: 2015-10-02 14:26:51 UTC
In all places where g_option_context_parse is being used, when it fails, the context and error variables are not getting freed, which will result in memory leaks. Along with that replacing g_error_free with g_clear_error in these files, which is a better way to free error, as it checks if the variable is Non-NULL and then sets it to NULL on freeing. Making it into 3 patches for better readability, based on folders of the files.(tools, tests, gst-libs).. If needed all these can be squashed into a single patch.
Created attachment 309659 [details] [review] gstreamer:base:tools: fix memory leaks during context parse failures. patch 1: tools folder
Created attachment 309660 [details] [review] gstreamer:base:tests: fix memory leaks during context parse failures. patch 2: tests folder
Created attachment 309661 [details] [review] mklicensestable: fix memory leaks during context parse failures. this doesn't get compiled. Did the change for complete coverage. Maybe we can skip this if not needed
Thanks, but please squash all the commits into one
Created attachment 309674 [details] [review] gstreamer:base: fix memory leaks during context parse failures.
Good find Vineeth :)
commit 8e5f7f27f56e567ab31bb3986f4963fc30c39443 Author: Vineeth TM <vineeth.tm@samsung.com> Date: Thu Aug 20 15:59:15 2015 +0900 gstreamer: base: Fix memory leaks when context parse fails. When g_option_context_parse fails, context and error variables are not getting free'd which results in memory leaks. Free'ing the same. And replacing g_error_free with g_clear_error, which checks if the error being passed is not NULL and sets the variable to NULL on free'ing. https://bugzilla.gnome.org/show_bug.cgi?id=753852