After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753823 - assrender: do not handle seek events
assrender: do not handle seek events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.6.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-19 12:58 UTC by Arnaud Vrac
Modified: 2015-11-10 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
just forward the seek event to sink pads (2.57 KB, patch)
2015-08-19 12:58 UTC, Arnaud Vrac 		reviewed Details | Review

Description Arnaud Vrac 2015-08-19 12:58:17 UTC 
Created attachment 309578 [details] [review]
just forward the seek event to sink pads

The event can just be forwarded, there's no reason to handle it ourselves.
Comment 1 Sebastian Dröge (slomo) 2015-08-19 13:39:31 UTC 
Any reason for this other than cleanup? The flushing and popping of text and unblocking might still be needed.
Comment 2 Arnaud Vrac 2015-08-19 14:07:20 UTC 
It's the same patch that was done in basetextoverlay a long time ago (Bug #735844). It's probably not 1.6.0 material.

It's a cleanup, but it might also make non-flushing seeks work better. I don't see why the text would need to be poped in this case. For flushing seeks the flush-start event will be sent, which assrender handles.
Comment 3 Arnaud Vrac 2015-11-10 14:52:15 UTC 
Tim pushed the same patch to master as commit 63853b7b0dbc8c (assrender: don't send flush events on seeks).
Comment 4 Tim-Philipp Müller 2015-11-10 15:02:01 UTC 
Oh, sorry!