GNOME Bugzilla – Bug 753813
dashdemux: replace use of xmlNodeDump as it is described as a deprecated function
Last modified: 2015-08-28 18:27:30 UTC
Created attachment 309546 [details] dashdemux: replace xmlNodeDump with xmlNodeDumpOutput Looking at the libxml documentation, the xmlNodeDump() function is described as "somehow deprecated, use xmlBufNodeDump() instead." [1] I am attaching a patch to replace this deprecated function. Not sure how much we really care. I've had one internal bug report about seg faults in the call to xmlNodeDump, but I don't have anything reproducible to put on this ticket. [1] http://xmlsoft.org/html/libxml-tree.html#xmlNodeDump
Created attachment 309547 [details] [review] dashdemux: replace xmlNodeDump with xmlNodeDumpOutput attachment of previous patch did not seem to work correctly (wrong MIME type).
commit 2ebebdbfbb7f5cfa7b438bb6b02fc723c9349d51 Author: Alex Ashley <bugzilla@ashley-family.net> Date: Wed Aug 19 11:29:43 2015 +0100 dashdemux: replace xmlNodeDump with xmlNodeDumpOutput When running on an STB, the function gst_mpdparser_get_xml_node_as_string causes a segmentation fault. This code works correctly on a Linux desktop. Looking at the libxml documentation, the xmlNodeDump is deprecated. Replacing the use of xmlNodeDump with xmlNodeDumpOutput fixes the segfault on the STB and removes the use of the deprecated function.
Created attachment 309606 [details] [review] dashdemux: replace xmlNodeDump with xmlNodeDumpOutput Previous patch did not handle the case where an encoding (e.g. UTF-8) is specified in the <xml ?> element. Added an extra test for with and without encoding.