GNOME Bugzilla – Bug 753779
tags: Add support for CinemaDNG EXIF tags
Last modified: 2018-11-03 11:40:28 UTC
Created attachment 309506 [details] [review] Patch file This patch adds support for the following CinemaDNG EXIF tags: /* Cinema DNG */ #define DNGTAG_TimeCodes 0xC763 /* 51043 */ #define DNGTAG_FrameRate 0xC764 /* 51044 */ #define DNGTAG_TStop 0xC772 /* 51058 */ #define DNGTAG_ReelName 0xC789 /* 51081 */ #define DNGTAG_CameraLabel 0xC7A1 /* 51105 */
Created attachment 309507 [details] [review] Patch with improved comments
Review of attachment 309507 [details] [review]: Please attach as a "git format-patch" style patch with a descriptive commit message ::: gst-libs/gst/tag/tag.h @@ +352,3 @@ + * GST_TAG_TIMECODES: + * + * Array of 8-byte timecode structures defined in SMPTE 331M-2004, Section 8.3 8 byte or 8 bit? The exif handling seems to use one byte @@ +358,3 @@ + * GST_TAG_FRAME_RATE: + * + * Fraction describing the frame rate of the video. The docs usually have the exact type of the tag in parenthesis at the end ::: gst-libs/gst/tag/tags.c @@ +200,3 @@ + gst_tag_register_static (GST_TAG_TIMECODES, GST_TAG_FLAG_META, + G_TYPE_BYTE_ARRAY, _("timecodes"), _("Array of timecodes (up to 10, " This should probably be a GstBuffer or GBytes
The timecode itself is 8 bytes (64 bits), and the official definition of the EXIF tag says that it is a byte array of length 8 * number-of-timecodes. I'm going to need to look at the EXIF writing code more closely, it looks like it is only writing a single byte of count 1, instead of a byte array. The spec for the CinemaDNG EXIF tags are here: http://wwwimages.adobe.com/content/dam/Adobe/en/devnet/cinemadng/pdfs/CinemaDNG_Format_Specification_v1_1.pdf
Created attachment 309712 [details] [review] 0001-Add-support-for-CinemaDNG.patch
Created attachment 309713 [details] [review] 0002-Move-CinemaDNG-definitions.patch
Created attachment 309714 [details] [review] 0003-The-writing-of-single-bytes-is-a-special-case.patch
Created attachment 309715 [details] [review] 0004-Add-support-for-the-EXIF_BYTE-type.patch
Created attachment 309716 [details] [review] 0005-Use-GST_TYPE_BUFFER-for-the-timecodes-type.patch
Turns out the EXIF code didn't support the EXIF_BYTE data type, this patch adds that support. Can someone review it to confirm I have done the right thing here?
Created attachment 313075 [details] [review] Add support for CinemaDNG Tags Patch for CinemaDNG tags to gstreamer.
Created attachment 313077 [details] [review] Add support for CinemaDNG Exif Patch for EXIF support for gst-plugins-base.
Patch updated for git master.
Created attachment 335219 [details] [review] gstreamer: Add support for CinemaDNG EXIF Tags Resolve conflicts in git master.
Created attachment 335220 [details] [review] gst-plugins-base: Add support for CinemaDNG EXIF Tags
Quick ping, any news?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/214.