After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753643 - build fails missing timezone map
build fails missing timezone map
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Date and Time
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: Kalev Lember
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-14 23:03 UTC by darkxst
Modified: 2015-08-18 06:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
datetime: Add UTC+08:30 timezone for North Korea (1.90 KB, patch)
2015-08-14 23:21 UTC, darkxst 		none Details | Review
update timezones for new "Pyongyang Time" (54.88 KB, patch)
2015-08-17 22:19 UTC, Frederic Peters 		accepted-commit_now Details | Review

Description darkxst 2015-08-14 23:03:05 UTC 
build fails with the following.

./test-timezone-gfx ./data
datetime-cc-panel-Message: File 'timezone_8.5.png' missing for zone 'Asia/Pyongyang'


Seems this is due to the North Korea time zone changing to UTC+08:30) in tzdata
Comment 1 darkxst 2015-08-14 23:21:40 UTC 
Created attachment 309312 [details] [review]
datetime: Add UTC+08:30 timezone for North Korea

These are symlinked to the previous image files until new ones are made
Comment 2 Antoine Jacoutot 2015-08-17 10:37:47 UTC 
I can confirm the initial breakage (on OpenBSD) and your patch fixes it.
All that's missing now are the images I guess.
Comment 3 Bastien Nocera 2015-08-17 18:56:31 UTC 
Review of attachment 309312 [details] [review]:

> previous image files

What "previous image files?
Comment 4 Frederic Peters 2015-08-17 22:19:28 UTC 
Created attachment 309427 [details] [review]
update timezones for new "Pyongyang Time"

Here's the patch with new images.

If there's no objection I'll apply it tomorrow before I roll a .90 tarball.
Comment 5 Bastien Nocera 2015-08-17 22:51:52 UTC 
Review of attachment 309427 [details] [review]:

I'm still not sure how you manage to fix the map without the sources, but it looks good!
Comment 6 Frederic Peters 2015-08-18 06:47:25 UTC 
Pushed.

commit cc600a918b2a6c34ae81cf85ef7b49a8e3f02ee6
Author: Frédéric Péters <fpeters@0d.be>
Date:   Tue Aug 18 00:16:44 2015 +0200

    datetime: update timezones for new "Pyongyang Time"
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753643