After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753525 - Configuration issues when using non-system location or non-released versions of libparted
Configuration issues when using non-system location or non-released versions ...
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2015-08-11 17:10 UTC by Mike Fleetwood
Modified: 2015-10-27 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix configuration issues with compiling with custom releases of libparted (v1) (9.66 KB, patch)
2015-08-18 09:59 UTC, Mike Fleetwood
none Details | Review

Description Mike Fleetwood 2015-08-11 17:10:47 UTC
Seen these issues when building GParted with libparted installed in non-
system location or with non-released versions of libparted:

1) Configuration based on the system provided version of libparted,
   rather than the the version linked with from the non-system location.

2) Configuration may miscompare versions of non-released version of
   libparted.
Comment 1 Mike Fleetwood 2015-08-18 09:59:00 UTC
Created attachment 309449 [details] [review]
Fix configuration issues with compiling with custom releases of libparted (v1)

Hi Curtis,

Here's a patchset to fix the above listed issues.

Thanks,
Mike
Comment 2 Curtis Gedak 2015-08-20 17:48:31 UTC
Thank you Mike for discovering this problem and providing a fix.  The patchset in comment #1 looks good to me.  As such I have committed it to the git repository for inclusion in the next release of GParted.

Hopefully you don't mind that I made one minor change to the title of the second patch
  FROM:
    effecting
  TO:
    affecting

The relevant git commits can be viewed at the following links:

Fix configuration version mismatch when using custom install of libparted (#753525)
https://git.gnome.org/browse/gparted/commit/?id=050366f6911d60c84803650bac117b30959f83af

Fix configuration version compare issue affecting libparted from GIT (#753525)
https://git.gnome.org/browse/gparted/commit/?id=bdbb6729f81162bc7814b6535beb09687b4df3c7
Comment 3 Curtis Gedak 2015-10-27 17:01:45 UTC
This enhancement was included in the GParted 0.24.0 release on October 27, 2015.