After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753430 - rtph264depay: Not working with caps "byte-stream/nal"
rtph264depay: Not working with caps "byte-stream/nal"
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal major
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-10 05:23 UTC by Hyunjun Ko
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtph264depay: checking if depay has sps/pps nals before insertion (800 bytes, patch)
2015-08-10 05:23 UTC, Hyunjun Ko
none Details | Review
rtph264depay: checking if depay has sps/pps nals before insertion (850 bytes, patch)
2015-08-10 05:25 UTC, Hyunjun Ko
committed Details | Review

Description Hyunjun Ko 2015-08-10 05:23:16 UTC
It's related to the commit http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/gst/rtp/gstrtph264depay.c?id=ef7863355c7c7eca24fbd92d6457a91c02f042ac

In gst_rtp_h264_set_src_caps, in case that byte_stream is true and sps and pps is NULL, this logic just does as below except for sps, pps insertion logic

----------------------------------------------
codec_data = gst_buffer_new_and_alloc (len);
gst_buffer_map (codec_data, &map, GST_MAP_WRITE);
data = map.data;

gst_buffer_unmap (codec_data, &map);
if (rtph264depay->codec_data)
  gst_buffer_unref (rtph264depay->codec_data);
rtph264depay->codec_data = codec_data;
---------------------------------------------
In this case, codec_data is gst buffer, which has NULL. (because len is 0)
This causes failure when playing.


Reproduce step : gst-rtsp-server / gst-launch playbin.
Comment 1 Hyunjun Ko 2015-08-10 05:23:55 UTC
Created attachment 308994 [details] [review]
rtph264depay: checking if depay has sps/pps nals before insertion
Comment 2 Hyunjun Ko 2015-08-10 05:25:01 UTC
Created attachment 308995 [details] [review]
rtph264depay: checking if depay has sps/pps nals before insertion
Comment 3 Sebastian Dröge (slomo) 2015-08-10 08:49:27 UTC
Thanks!

commit 9c5c16eb57c1b12d10cb2bca7c4abd59e04583eb
Author: Hyunjun Ko <zzoon.ko@samsung.com>
Date:   Mon Aug 10 14:13:50 2015 +0900

    rtph264depay: checking if depay has sps/pps nals before insertion
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753430