After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753397 - [HighContrast] GtkPathBar icons (root/home) are black on black and need more padding
[HighContrast] GtkPathBar icons (root/home) are black on black and need more ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2015-08-08 15:29 UTC by Arnaud B.
Modified: 2015-09-04 06:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot, from a filechooser. See (or not) the “root folder” icon, and the lack of right padding of “triton”’s one. (3.59 KB, image/png)
2015-08-08 15:29 UTC, Arnaud B.
Details
Screenshot of the black pathbar icon not being overridden by the inspector css (38.11 KB, image/png)
2015-09-03 15:15 UTC, Lapo Calamandrei
Details

Description Arnaud B. 2015-08-08 15:29:33 UTC
Created attachment 308954 [details]
Screenshot, from a filechooser. See (or not) the “root folder” icon, and the lack of right padding of “triton”’s one.

When using the HighContrast theme, the GtkPathBar widget (as seen in the filechooser) has “root” and “user’s home” icons (are there some others?) that are displayed black on black on the current folder. And the “user’s home” one needs more padding at the right, for separation with the user’s home folder name.
Comment 1 Matthias Clasen 2015-08-08 15:52:50 UTC
I think this will probably be fixed as a side-effect of the GtkPathBar rewrite. Right, Carlos ?
Comment 2 Lapo Calamandrei 2015-09-03 14:49:29 UTC
This takes care about the padding issue.

commit 57894ec55b85bed7acbc669963b9c5416af9bb37
Author: Lapo Calamandrei <calamandrei@gmail.com>
Date:   Thu Sep 3 16:46:36 2015 +0200

    HC: fix pathbar paddings.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=753397 for
    details.
Comment 3 Lapo Calamandrei 2015-09-03 15:05:05 UTC
The black icons issue doesn't look like a theme bug to me.
Comment 4 Lapo Calamandrei 2015-09-03 15:15:13 UTC
Created attachment 310606 [details]
Screenshot of the black pathbar icon not being overridden by the inspector css
Comment 5 Matthias Clasen 2015-09-03 16:00:35 UTC
it isn't a theme bug
Comment 6 Carlos Soriano 2015-09-03 17:03:33 UTC
(In reply to Matthias Clasen from comment #1)
> I think this will probably be fixed as a side-effect of the GtkPathBar
> rewrite. Right, Carlos ?

Probably yes, I will use a composite widget as much as I can (although the allocation will be somewhat tricky anyway), so it should change for 3.20.
Comment 7 Arnaud B. 2015-09-03 17:22:04 UTC
Looks like “GtkPathBar { color:red; }” works for changing the color of the icons (and “GtkPathBar * { color:red; }” for the texts).