After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753357 - [HighContrast] Days of a different month in GtkCalendar should be grey, not black
[HighContrast] Days of a different month in GtkCalendar should be grey, not b...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-08-07 15:21 UTC by Arnaud B.
Modified: 2015-08-31 08:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot. July 27 to July 31 and September 1 to September 6 should be grey. (11.33 KB, image/png)
2015-08-07 15:21 UTC, Arnaud B.
  Details
Adwaita, HighContrast: day names in GtkCalendar (112.50 KB, patch)
2015-08-27 14:26 UTC, Jakub Steiner
committed Details | Review

Description Arnaud B. 2015-08-07 15:21:27 UTC
Created attachment 308905 [details]
Screenshot. July 27 to July 31 and September 1 to September 6 should be grey.

When using the HighContrast theme, the days of the previous and next months in a GtkCalendar are written in black (on white), as the days of the current month. I do think using lighter would be clearer for understanding (as it is in Adwaita).
Comment 1 Arnaud B. 2015-08-08 14:28:02 UTC
I’m reopening as I’m not happy with the pushed fix: it also makes the day-in-the-week (mon., tue., etc.) go grey. I don’t see a good reason for that, we’re not loosing an information in having it black, and it’s a quite important information.
Comment 2 Matthias Clasen 2015-08-08 15:55:28 UTC
Its the same appearance under Adwaita, though.
Comment 3 Arnaud B. 2015-08-08 16:21:01 UTC
It may be considered prettier to have it grey on Adwaita (I honestly don’t care), but the main goal of HighContrast as I understand it is to ensure the best readability possible without losing information. So, black.
Comment 4 Jakub Steiner 2015-08-25 11:51:03 UTC
I would definitely style the day names row differently, even in Adwaita. I don't see it exposed in any way to the theme though.
Comment 5 Matthias Clasen 2015-08-27 03:01:43 UTC
I've pushed a commit that shows how its done
Comment 6 Jakub Steiner 2015-08-27 14:26:45 UTC
Created attachment 310100 [details] [review]
Adwaita, HighContrast: day names in GtkCalendar

Ideally I'd like to mimic the treeview column-header style,
but font-weight: bold; doesn't seem to work. Making them plain
for now.
Comment 7 Jakub Steiner 2015-08-31 08:12:27 UTC
Attachment 310100 [details] pushed as c5d195c - Adwaita, HighContrast: day names in GtkCalendar