After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753338 - value: free caps during failure
value: free caps during failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-07 01:08 UTC by Vineeth
Modified: 2015-08-16 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unref caps during failure cases (1.44 KB, patch)
2015-08-07 01:11 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-08-07 01:08:15 UTC 
While calling gst_value_deserialize_sample, if there is a failure after caps is ref'ed, then caps is getting leaked. Hence checking for caps in 
fail: goto condition and unref'ing it
Comment 1 Vineeth 2015-08-07 01:11:56 UTC 
Created attachment 308872 [details] [review]
unref caps during failure cases
Comment 2 Sebastian Dröge (slomo) 2015-08-07 08:17:30 UTC 
commit 0eb9dde1e803cfff490632553a13f705693710b6
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Fri Aug 7 10:08:21 2015 +0900

    value: free caps during failure
    
    While calling gst_value_deserialize_sample, if there is a failure
    after caps is ref'ed, then caps is getting leaked. Hence checking for
    caps in fail: goto condition and unref'ing it
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753338