After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753129 - HighContrast: connect to server entry in file chooser
HighContrast: connect to server entry in file chooser
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-08-01 13:42 UTC by Matthias Clasen
Modified: 2015-09-04 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
HighContrast: make linked entries align (10.04 KB, patch)
2015-09-03 10:18 UTC, Jakub Steiner 		none Details | Review
HighContrast: make linked entries align (67.50 KB, patch)
2015-09-04 13:26 UTC, Jakub Steiner 		committed Details | Review

Description Matthias Clasen 2015-08-01 13:42:18 UTC 
The entry looks too narrow compared to the linked button with its fat outline. Maybe this is a layout bug, and not a theme issue ?
Comment 1 Arnaud B. 2015-08-08 15:36:19 UTC 
.linked GtkEntry { border-width:2px; padding-top:6px; padding-bottom:6px; }
more or less (padding value…) does the job here if I correctly found the bug you’ve seen, so it’s a theming issue I think.
Comment 2 Jakub Steiner 2015-09-03 10:18:48 UTC 
Created attachment 310577 [details] [review]
HighContrast: make linked entries align

- reshuffled the stylesheet to easily allow having a thicker
  border, but decided to keep the 1px borders on entries
  as it makes easier to spot the buttons despite being flat.
Comment 3 Lapo Calamandrei 2015-09-04 13:03:17 UTC 
The patch looks good to me, but I'd make generally make entries and button the same height, hence I'll directly set the padding on .entry.
Any particular reason not to have buttons and entries the same height?
Comment 4 Jakub Steiner 2015-09-04 13:26:33 UTC 
Created attachment 310669 [details] [review]
HighContrast: make linked entries align

- reshuffled the stylesheet to easily allow having a thicker
  border, but decided to keep the 1px borders on entries
  as it makes easier to spot the buttons despite being flat.
Comment 5 Jakub Steiner 2015-09-04 13:26:53 UTC 
Attachment 310669 [details] pushed as 5b7bed6 - HighContrast: make linked entries align