Created attachment 308503 [details] [review]
stream IDs should not be compared.

The changes made are
First compare stream IDs
If different
   Check if it is local file and continue
   else return -1

If same
   Compare caps
      If same continue
      Else return 0 and continue checking for the next stream.

Compare tags
return 1



Previously it was written such that, if stream IDs are equal, then we are expecting the caps also to be equal, and hence throwing error if not.
But now that is not needed. Hence continuing to the next stream.


please review

Review of attachment 308503 [details] [review]:

This is incorrect solution.

::: validate/gst/validate/media-descriptor.c
@@ +297,3 @@
+    else
+      return -1;
+  }

This changes the test completly. What it was doing is checking that for the same stream ID we have the same caps, which, for any URI is valid.

@@ +301,2 @@
+  if (!gst_caps_is_equal (rstream->caps, cstream->caps))
+    return 0;

And now you check it but don't set the error/warning message anymore.

I've been thinking a bit about that. A special case in stream ID comparison could be made. If we look at the structure of a filesrc base ID we get:

<file-path-hash>/<stream-specific-id>

What we could do is that if we have a file:// URI, we could skip to / (if it exist), in order to make the comparision. This way we can still check and warn if for two matching stream ID we don't have the expected caps.

Created attachment 308586 [details] [review]
validate: media-descriptor: Workaround file:// stream-id changing

file:// base stream-id will vary depending on the file path. As we
don't expect everyone to use the same absolute path to place the
validate testsuite, the resulting stream-id changes. Because of that,
we can't match the stream-id in the recorded file, hence cannot do
further check. We work around this by doing what filesink would do,
which is compute a SHA256 of the URI which we can use to first
validate the ID is prefixed like expected, and decide if we should
consider the stream IDs the same or not.

Attachment 308586 [details] pushed as 6993666 - validate: media-descriptor: Workaround file:// stream-id changing