After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753013 - Allow to use nested namespaces in --namespace parameter (generate_wrap_init.pl)
Allow to use nested namespaces in --namespace parameter (generate_wrap_init.pl)
Status: RESOLVED FIXED
Product: glibmm
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2015-07-29 11:35 UTC by Marcin Kolny (IRC: loganek)
Modified: 2015-07-30 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed solution (1.02 KB, patch)
2015-07-29 11:35 UTC, Marcin Kolny (IRC: loganek) 		committed Details | Review

Description Marcin Kolny (IRC: loganek) 2015-07-29 11:35:28 UTC 
generate_wrap_init.pl doesn't give us possibility to write wrap_init() function inside nested namespace. E.g., instead of:
Gst::Bad::wrap_init() 
we have to use 
GstBad::wrap_init().
Advantage of nested namespaces is grouping modules in logic structure.
Comment 1 Marcin Kolny (IRC: loganek) 2015-07-29 11:35:59 UTC 
Created attachment 308382 [details] [review]
proposed solution
Comment 2 Kjell Ahlstedt 2015-07-30 10:00:16 UTC 
Review of attachment 308382 [details] [review]:

Ok. Looks innocent enough. I suppose you have tested it.
It would be fine, if you include the bug number in the commit message.
Comment 3 Marcin Kolny (IRC: loganek) 2015-07-30 10:14:40 UTC 
Ok, thanks for review. I added bug number to commit message and pushed to master branch.