After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752991 - h263parse: fix caps memory leak
h263parse: fix caps memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-29 03:56 UTC by Vineeth
Modified: 2015-08-16 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix caps memory leak (837 bytes, patch)
2015-07-29 03:57 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-07-29 03:56:48 UTC 
while setting the src caps, sink caps is being ref'ed but not unref'ed
Comment 1 Vineeth 2015-07-29 03:57:33 UTC 
Created attachment 308352 [details] [review]
fix caps memory leak
Comment 2 Tim-Philipp Müller 2015-07-29 08:27:17 UTC 
With your patch applied:

tpm@xps:~/gst/glib-master/gst-plugins-bad/tests/check$ make elements/h263parse.check
Running suite(s): h263parse
0%: Checks: 4, Failures: 4, Errors: 0
gstcheck.c:79:F:general:test_parse_normal:0: Unexpected critical/warning: gst_mini_object_unref: assertion 'mini_object != NULL' failed
gstcheck.c:79:F:general:test_parse_drain_single:0: Unexpected critical/warning: gst_mini_object_unref: assertion 'mini_object != NULL' failed
gstcheck.c:79:F:general:test_parse_split:0: Unexpected critical/warning: gst_mini_object_unref: assertion 'mini_object != NULL' failed
gstcheck.c:79:F:general:test_parse_detect_stream:0: Unexpected critical/warning: gst_mini_object_unref: assertion 'mini_object != NULL' failed


Fixed by adding an if (sink_caps), but please run 'make check' before submitting patches.

commit 9b43bed6073b72b1a66a43a260cf38b309fe8773
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Wed Jul 29 12:56:54 2015 +0900

    h263parse: fix caps memory leak
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752991
Comment 3 Tim-Philipp Müller 2015-07-29 08:27:36 UTC 
Comment on attachment 308352 [details] [review]
fix caps memory leak

pushed with changes.
Comment 4 Vineeth 2015-07-29 08:36:11 UTC 
Okey will do that from next time.. thanks :)