After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752901 - Add translator comment or fix string
Add translator comment or fix string
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2015-07-26 17:29 UTC by Alexandre Franke
Modified: 2015-08-03 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add partition flag translator comments (v1) (2.27 KB, patch)
2015-07-27 16:00 UTC, Curtis Gedak 		none Details | Review

Description Alexandre Franke 2015-07-26 17:29:42 UTC 
The string "Skip setting unsupported partition flag: %1" is really not clear and it's quite difficult to translate it. Please either change it to make it easier to understand, or provide a translation comment.

https://wiki.gnome.org/TranslationProject/DevGuidelines/Use%20comments
Comment 1 Curtis Gedak 2015-07-27 16:00:45 UTC 
Created attachment 308230 [details] [review]
Add partition flag translator comments (v1)

Thank you Alexandre for indicating an area for improvement with a link to how to add translator comments.

Attached is patch v1 that adds translator comments in this section of code that deals with setting partition flags (or skipping this step if the partition table does not support the particular partition flag we wish to set).

Do the translator comments in the attached patch v1 address your concern?

If not, please feel free to suggest a better comment or alternative wording.

Curtis
Comment 2 Alexandre Franke 2015-07-27 16:48:44 UTC 
The explanation you provide helps to understand the string. Thanks.
Comment 3 Mike Fleetwood 2015-07-27 17:00:21 UTC 
Pushed patch from comment #1 to the Git repo:

Add translation comments for code section setting partition flag (#752901)
https://git.gnome.org/browse/gparted/commit/?id=0dc05fdf3beb1063def4b8a50fba6d8ce64f2681

Thanks,
Mike
Comment 4 Curtis Gedak 2015-08-03 17:36:14 UTC 
This enhancement was included in the GParted 0.23.0 release on August 3, 2015.