GNOME Bugzilla – Bug 752834
doesn't set filesystem::type
Last modified: 2015-09-11 06:27:35 UTC
I'm using filesystem::type in the file chooser search to find remote locations, so I noticed that some gvfs backends don't set this attribute.
Created attachment 308185 [details] [review] Set filesystem::type for all backends This attribute was being set inconsistently, and is used by the file chooser.
Review of attachment 308185 [details] [review]: Looks good, thanks!
(In reply to Matthias Clasen from comment #0) > I'm using filesystem::type in the file chooser search to find remote > locations, so I noticed that some gvfs backends don't set this attribute. gtk/gtkfilesystem.c-static const gchar * const remote_types[] = { gtk/gtkfilesystem.c- "sftp", gtk/gtkfilesystem.c- "webdav", gtk/gtkfilesystem.c- "ftp", gtk/gtkfilesystem.c- "nfs", gtk/gtkfilesystem.c: "cifs", gtk/gtkfilesystem.c- NULL gtk/gtkfilesystem.c-}; You might want to add also afp...
Pushed to master as c40c301. Thanks for the review.
Umm... can't we close this now?
(In reply to Ondrej Holy from comment #3) > You might want to add also afp... This has been done in bug 754746.
Thanks!