After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752834 - doesn't set filesystem::type
doesn't set filesystem::type
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: ftp backend
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-24 16:36 UTC by Matthias Clasen
Modified: 2015-09-11 06:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set filesystem::type for all backends (11.59 KB, patch)
2015-07-26 21:25 UTC, Ross Lagerwall
committed Details | Review

Description Matthias Clasen 2015-07-24 16:36:02 UTC
I'm using filesystem::type in the file chooser search to find remote locations, so I noticed that some gvfs backends don't set this attribute.
Comment 1 Ross Lagerwall 2015-07-26 21:25:47 UTC
Created attachment 308185 [details] [review]
Set filesystem::type for all backends

This attribute was being set inconsistently, and is used by the file
chooser.
Comment 2 Ondrej Holy 2015-08-04 07:41:40 UTC
Review of attachment 308185 [details] [review]:

Looks good, thanks!
Comment 3 Ondrej Holy 2015-08-04 10:53:38 UTC
(In reply to Matthias Clasen from comment #0)
> I'm using filesystem::type in the file chooser search to find remote
> locations, so I noticed that some gvfs backends don't set this attribute.

gtk/gtkfilesystem.c-static const gchar * const remote_types[] = {
gtk/gtkfilesystem.c-  "sftp",
gtk/gtkfilesystem.c-  "webdav",
gtk/gtkfilesystem.c-  "ftp",
gtk/gtkfilesystem.c-  "nfs",
gtk/gtkfilesystem.c:  "cifs",
gtk/gtkfilesystem.c-  NULL
gtk/gtkfilesystem.c-};

You might want to add also afp...
Comment 4 Ross Lagerwall 2015-08-04 20:03:39 UTC
Pushed to master as c40c301. Thanks for the review.
Comment 5 Debarshi Ray 2015-09-08 16:33:52 UTC
Umm... can't we close this now?
Comment 6 Ross Lagerwall 2015-09-10 20:49:10 UTC
(In reply to Ondrej Holy from comment #3)
> You might want to add also afp...

This has been done in bug 754746.
Comment 7 Ondrej Holy 2015-09-11 06:27:35 UTC
Thanks!