GNOME Bugzilla – Bug 752688
wayland: improve check for wayland-scanner
Last modified: 2016-02-16 15:46:43 UTC
See attached patch
Created attachment 307869 [details] [review] configure: improve check for wayland-scanner binary The plugin doesn't need the wayland-scanner package to be built or run, it only needs the wayland-scanner program during compile time. When cross-compiling, build systems might not have the wayland-scanner package for the target system as it is a developer's tool, while it should still be possible to use wayland-scanner from the host system. This patch fixes it by not requiring the wayland-scanner package but just the binary itself. Note that the check is done outside of the PKG_CHECK_MODULES as it doesn't work inside of it.
Comment on attachment 307869 [details] [review] configure: improve check for wayland-scanner binary Why do we check once with AC_CHECK_PROG and once with AC_PATH_PROG? The latter should probably also only be done if HAVE_WAYLAND is yes, no?
Created attachment 320905 [details] [review] configure: improve check for wayland-scanner binary Updated to only check for wayland-scanner once. Works in my desktop and my cross-compiling scenario.
commit b5a4de197a24016e6893b5428e893887b9443454 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Tue Jul 21 18:02:38 2015 -0300 configure: improve check for wayland-scanner binary The plugin doesn't need the wayland-scanner package to be built or run, it only needs the wayland-scanner program during compile time. When cross-compiling, build systems might not have the wayland-scanner package for the target system as it is a developer's tool, while it should still be possible to use wayland-scanner from the host system. This patch fixes it by not requiring the wayland-scanner package but just the binary itself. Note that the check is done outside of the PKG_CHECK_MODULES as it doesn't work inside of it. https://bugzilla.gnome.org/show_bug.cgi?id=752688