After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752674 - screen: On monitors-changed, update the window monitor before resizing
screen: On monitors-changed, update the window monitor before resizing
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-21 14:46 UTC by Rui Matos
Modified: 2015-07-21 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screen: On monitors-changed, update the window monitor before resizing (1.56 KB, patch)
2015-07-21 14:46 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2015-07-21 14:46:07 UTC
Since commit 14b0a83f64134fd6669d580558e10b4a225cb1d6 we store the
main window monitor instead of computing it every time. This means
that we must now ensure that it's updated before trying to use it
which we do from meta_screen_resize_func() or else we'll crash on an
assertion later on when removing a monitor:

assertion failed: (which_monitor < workspace->screen->n_monitor_infos)
Comment 1 Rui Matos 2015-07-21 14:46:11 UTC
Created attachment 307834 [details] [review]
screen: On monitors-changed, update the window monitor before resizing
Comment 2 Jasper St. Pierre (not reading bugmail) 2015-07-21 15:41:41 UTC
Review of attachment 307834 [details] [review]:

OK.
Comment 3 Rui Matos 2015-07-21 15:47:16 UTC
Attachment 307834 [details] pushed as 7e1c6ff - screen: On monitors-changed, update the window monitor before resizing