After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752655 - qtdemux: support 'subt' subtype for subtitle tracks
qtdemux: support 'subt' subtype for subtitle tracks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other other
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-21 05:17 UTC by Paul Kim
Modified: 2015-08-16 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch to support fourcc_subt (2.00 KB, patch)
2015-07-21 05:22 UTC, Paul Kim 		none Details | Review
Support subtitle when track subtype is fourcc_subt (1.99 KB, patch)
2015-07-21 11:09 UTC, Paul Kim 		committed Details | Review

Description Paul Kim 2015-07-21 05:17:58 UTC 
When testing the mpd below that contains subtitle data, crash occurs.
Comment 1 Paul Kim 2015-07-21 05:22:58 UTC 
Created attachment 307794 [details] [review]
A patch to support fourcc_subt
Comment 2 Paul Kim 2015-07-21 05:23:35 UTC 
@matej.knopp@gmail.com
Comment 3 Paul Kim 2015-07-21 05:24:42 UTC 
@matej.knopp@gmail.com, please take a look at this simple change. Thanks.
Comment 4 Tim-Philipp Müller 2015-07-21 10:33:16 UTC 
Yes, but it should also not crash if the subtype is not supported.

Could you provide a stack trace?
Comment 5 Paul Kim 2015-07-21 11:09:32 UTC 
Created attachment 307822 [details] [review]
Support subtitle when track subtype is fourcc_subt
Comment 6 Paul Kim 2015-07-21 11:10:13 UTC 
Oh.. My bad! The crash did not come from upstream qtdemux, but from my own system. However, the track subtype of this mpd (http://rdmedia.bbc.co.uk/dash/ondemand/elephants_dream/1/client_manifest-all.mpd) is observed as "subt", so we may still need to consider this change.
I revised the commit message and uploaded as new patch.
Comment 7 Tim-Philipp Müller 2015-07-21 11:25:47 UTC 
Pushed, thanks:

commit 3740e69957a6cac7b7e9dae992e04335f966213a
Author: Paul Hyunil <paul.hyunil@lge.com>
Date:   Thu Jul 16 09:32:36 2015 +0900

    qtdemux: Support subtitle when track subtype is fourcc_subt
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752655