After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752516 - use GResource to bundle UI files
use GResource to bundle UI files
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2015-07-17 02:15 UTC by Daiki Ueno
Modified: 2015-08-03 06:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Suppress compiler warnings (1.81 KB, patch)
2015-07-17 02:15 UTC, Daiki Ueno
none Details | Review
build: Don't remove version controlled C files (853 bytes, patch)
2015-07-17 02:15 UTC, Daiki Ueno
none Details | Review
build: Embed UI files as GResource (18.03 KB, patch)
2015-07-17 02:15 UTC, Daiki Ueno
none Details | Review
build: Bundle data files as GResource (19.09 KB, patch)
2015-07-24 04:00 UTC, Daiki Ueno
none Details | Review
build: Bundle data files as GResource (14.43 KB, patch)
2015-08-01 22:39 UTC, Daiki Ueno
none Details | Review

Description Daiki Ueno 2015-07-17 02:15:11 UTC
When I was experimenting a few UI changes, I found it a bit cumbersome to run "make install" every time I made changes to *.xml.  This series of patches switch to GResource and fix some minor build issues.
Comment 1 Daiki Ueno 2015-07-17 02:15:14 UTC
Created attachment 307594 [details] [review]
build: Suppress compiler warnings

Add missing casts related to search provider.
Comment 2 Daiki Ueno 2015-07-17 02:15:18 UTC
Created attachment 307595 [details] [review]
build: Don't remove version controlled C files

Since all *.c and *.h files generated from *.vala are registered to
BUILT_SOURCES by sub-Makefiles, we don't need to clean them manually.
Otherwise, version controlled source code will be removed on "make
clean".
Comment 3 Daiki Ueno 2015-07-17 02:15:22 UTC
Created attachment 307596 [details] [review]
build: Embed UI files as GResource

To make it possible to test UI changes without installing UI files,
bundle them in the seahorse executable, using GResource.
Comment 4 Daiki Ueno 2015-07-24 04:00:08 UTC
Created attachment 308046 [details] [review]
build: Bundle data files as GResource

To make it possible to test UI changes without installing UI files,
bundle them in the seahorse executable, using GResource.
Comment 5 Daiki Ueno 2015-07-24 04:04:09 UTC
Comment on attachment 307596 [details] [review]
build: Embed UI files as GResource

Removed seahorse.gresource.xml itself from seahorse.gresource.xml, and moved it under libseahorse for consistency.
Comment 6 Daiki Ueno 2015-08-01 22:39:00 UTC
Created attachment 308626 [details] [review]
build: Bundle data files as GResource

To make it possible to test UI changes without installing UI files,
bundle them in the seahorse executable, using GResource.
--
Changes from the previous patch:

- generate seahorse.gresource.xml on-the-fly, in a similar way to gtk+:
  https://git.gnome.org/browse/gtk+/tree/gtk/Makefile.am#n1148
- try to make code changes minimal
Comment 7 Stef Walter 2015-08-03 06:36:15 UTC
Awesome. Thanks! Merged.

Attachment 307594 [details] pushed as b2d9320 - build: Suppress compiler warnings
Attachment 307595 [details] pushed as 015aae7 - build: Don't remove version controlled C files
Attachment 308626 [details] pushed as 9d12b99 - build: Bundle data files as GResource