After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752333 - dashdemux: durations should be validated
dashdemux: durations should be validated
Status: RESOLVED DUPLICATE of bug 750847
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-13 14:59 UTC by Florin Apostol
Modified: 2016-02-25 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Florin Apostol 2015-07-13 14:59:45 UTC
The following fields contain duration values and should be checked that they contain only positive values:
GstPeriodNode start
GstPeriodNode duration
GstMetricsRangeNode startTime
GstMetricsRangeNode duration
GstMPDNode mediaPresentationDuration
GstMPDNode minimumUpdatePeriod
GstMPDNode minBufferTime
GstMPDNode timeShiftBufferDepth
GstMPDNode maxSegmentDuration
GstMPDNode maxSubsegmentDuration

(I'm not sure if GstMPDNode's suggestedPresentationDelay is allowed to have negative values.)

These fields have type gint64 and are set to -1 if the information is not found in the xml file. Ideally they should have the type GstClockTime and a default value of GST_CLOCK_TIME_NONE if not present. But that require changes in the API and careful changes in the code, because they currently represent values measured in milliseconds and GstClockTime holds values measured in nanoseconds.

At least we should check that their values are positive and reject xml files with negative values for those fields.
Comment 1 Vincent Penquerc'h 2015-09-17 11:09:58 UTC

*** This bug has been marked as a duplicate of bug 750847 ***