After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752326 - dashdemux: parser should reject MPD files with negative mediaPresentationDuration
dashdemux: parser should reject MPD files with negative mediaPresentationDura...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-13 12:54 UTC by Florin Apostol
Modified: 2015-10-29 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (2.69 KB, patch)
2015-07-13 12:57 UTC, Florin Apostol 		none Details | Review
proposed patch (2.75 KB, patch)
2015-07-13 13:40 UTC, Florin Apostol 		none Details | Review
proposed patch (2.73 KB, patch)
2015-07-13 13:42 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-07-13 12:54:21 UTC 
If a negative period is provided for mediaPresentationDuration, the parser will accept that and interpret it as an unsigned value. It should reject negative values for mediaPresentationDuration
Comment 1 Florin Apostol 2015-07-13 12:57:15 UTC 
Created attachment 307344 [details] [review]
proposed patch

attached unit test and proposed fix
Comment 2 Florin Apostol 2015-07-13 13:40:12 UTC 
Created attachment 307348 [details] [review]
proposed patch

updated patch: changed the unit test function name
Comment 3 Florin Apostol 2015-07-13 13:42:56 UTC 
Created attachment 307349 [details] [review]
proposed patch

changed (again) the unit test function name
Comment 4 Vincent Penquerc'h 2015-10-29 10:59:09 UTC 
commit cdfec060921fd2343516467b2430c5e8ca01d120
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Wed Oct 28 16:31:39 2015 +0000

    dashdemux: parser rejects negative values for mediaPresentationDuration
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752326