After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752319 - Update text Interface deprecated functions by implementing get_string_at_offset
Update text Interface deprecated functions by implementing get_string_at_offset
Status: RESOLVED OBSOLETE
Product: java-atk-wrapper
Classification: Applications
Component: general
0.33.x
Other All
: Normal normal
: ---
Assigned To: Magdalen Berns (irc magpie)
java-atk-wrapper maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-07-13 11:28 UTC by Magdalen Berns (irc magpie)
Modified: 2021-05-17 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove text_get before/after offset (14.80 KB, patch)
2015-07-19 13:32 UTC, Magdalen Berns (irc magpie)
committed Details | Review
The Granularity interface needed to get "part". (1.91 KB, patch)
2015-07-19 13:33 UTC, Magdalen Berns (irc magpie)
committed Details | Review
update HACKING (878 bytes, patch)
2015-08-12 12:21 UTC, Magdalen Berns (irc magpie)
committed Details | Review

Description Magdalen Berns (irc magpie) 2015-07-13 11:28:49 UTC
The following three functions can be replaced with a single function named jaw_text_get_string_at_offset in jawtext.c.[1,2]

 1. get_text_after_offset
 2. get_text_at_offset
 3. get_text_before_offset

The jaw_text_get_string_at_offset function, should implement the AtkText pointer and call getStringAtOffset from the AtkText wrapper class.

[1] https://git.gnome.org/browse/atk/tree/atk/atktext.h#n331
[2] https://git.gnome.org/browse/java-atk-wrapper/tree/jni/src/jawtext.c
Comment 1 Magdalen Berns (irc magpie) 2015-07-19 13:32:25 UTC
Created attachment 307676 [details] [review]
remove text_get before/after offset

There are some problems with get_string_at_offset compatibility so get_text_at_offset may have to stick around.

At the moment the implementation of get_string_at_offset being tested doesn't get a string and Orca says "blank" unless the text is expected.

This is with an implementation which should logically work so I suspect there is something going on with some compatibility layer or something. I am going to do some further texts with a couple of different applications to check it's not only on SwingSet that this happens.

I'll also put a draft patch off get_string_at_offset up in a bit and ping the list about it to see if anyone has any ideas.
Comment 2 Magdalen Berns (irc magpie) 2015-07-19 13:33:50 UTC
Created attachment 307677 [details] [review]
The Granularity interface needed to get "part".
Comment 3 Magdalen Berns (irc magpie) 2015-08-12 12:21:00 UTC
Created attachment 309141 [details] [review]
update HACKING
Comment 4 GNOME Infrastructure Team 2021-05-17 15:40:53 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/java-atk-wrapper/-/issues/20.