GNOME Bugzilla – Bug 752292
Add new syntax for The Meson Build System
Last modified: 2015-07-23 11:35:49 UTC
Meson is an open source build system meant to be both extremely fast, and, even more importantly, as user friendly as possible. Currently meson highlight is a bit simplified, but in the future we are planning to make it much better ;) Reference: http://mesonbuild.com/ Language Reference: https://github.com/mesonbuild/meson/wiki/Reference-manual/cb3ef7a131afe067f56143e0c0f24817b3617315 Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Created attachment 307314 [details] [review] language-specs: new highlight for meson Meson is an open source build system meant to be both extremely fast, and, even more importantly, as user friendly as possible. Currently meson highlight is a bit simplified, but in the future we are planning to make it much better ;) The Meson Build System: http://mesonbuild.com/ Language Reference: https://github.com/mesonbuild/meson/wiki/Reference-manual/cb3ef7a131afe067f56143e0c0f24817b3617315 Reference: https://bugzilla.gnome.org/show_bug.cgi?id=752292 Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Review of attachment 307314 [details] [review]: Looks good, but you need to update POTFILES.in too. Also, it's better to have an example in tests/syntax-highlighting/.
Created attachment 307668 [details] [review] language-specs: new highlight for meson Meson is an open source build system meant to be both extremely fast, and, even more importantly, as user friendly as possible. Currently meson highlight is a bit simplified, but in the future we are planning to make it much better ;) v2: add meson.lang to POTFILES.in and add example file for testing The Meson Build System: http://mesonbuild.com/ Language Reference: https://github.com/mesonbuild/meson/wiki/Reference-manual/cb3ef7a131afe067f56143e0c0f24817b3617315 Reference: https://bugzilla.gnome.org/show_bug.cgi?id=752292 Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Review of attachment 307668 [details] [review]: A language definition file shipped by GtkSourceView needs to have a mimetype defined in the shared-mime-info database. Sorry to not have spotted it at the first review.
(In reply to Sébastien Wilmet from comment #4) > Review of attachment 307668 [details] [review] [review]: > > A language definition file shipped by GtkSourceView needs to have a mimetype > defined in the shared-mime-info database. Sorry to not have spotted it at > the first review. okay, I will take it ;)
The patch to add this has been submitted to fdo bugzilla here: https://bugs.freedesktop.org/show_bug.cgi?id=91397
http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=962056d5f178cd0b2fc3fc3788058b7dfe878928 Done in upstream shared-mime-info database :)
Cool! Can you add the mimetype to the lang file?
Created attachment 307982 [details] [review] language-specs: new highlight for meson Meson is an open source build system meant to be both extremely fast, and, even more importantly, as user friendly as possible. Currently meson highlight is a bit simplified, but in the future we are planning to make it much better ;) v2: add meson.lang to POTFILES.in and add example file for testing v3: add text/x-meson to mimetypes and add meson_options.txt to matching files The Meson Build System: http://mesonbuild.com/ Language Reference: https://github.com/mesonbuild/meson/wiki/Reference-manual/cb3ef7a131afe067f56143e0c0f24817b3617315 Related: http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=962056d5f178cd0b2fc3fc3788058b7dfe878928 Reference: https://bugzilla.gnome.org/show_bug.cgi?id=752292 Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
Review of attachment 307982 [details] [review]: Looks good.
Attachment 307982 [details] pushed as f8b78d5 - language-specs: new highlight for meson