After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752204 - .gml2 files are modified during build
.gml2 files are modified during build
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
2.6.7
Other Linux
: Normal normal
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2015-07-10 04:52 UTC by Dmitry Smirnov
Modified: 2018-06-29 23:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dmitry Smirnov 2015-07-10 04:52:25 UTC
Files src/backend/xml/test/test-files/*.gml2 are modified during build but not cleaned.
Comment 1 Mike Evans 2015-07-10 08:31:07 UTC
Are you running "make clean" and "make distclean" ?

If you are worried about generated/changes files being left on you system then you might consider building outside the source tree.

In your gnucash source base dir do:
mkdir build
cd build
../configure $YOUR_OPTIONS

Then run make from the build dir, this keeps generated files outside the source tree.

http://wiki.gnucash.org/wiki/Building

You can also run git clean -r to remove files that are not part of the original git clone of gnucash.

Also which branch are you building master or maint ?
Comment 2 Dmitry Smirnov 2015-07-10 08:57:51 UTC
I'm the maintainer of GnuCash in Debian so yes, build environment is clean. :)

From our QA prospective it is not nice that GnuCash build system modifies its own source tree so second build in the same tree may not be exactly the same.

I've notice that during re-build of the GnuCash v2.6.7 (from source tarball, outside of git repository).

The problem with those .gml2 files is that they are apparently not generated during build-time as removing them before build resulting FTBFS.
This is a minor problem with build system...
Comment 3 Mike Evans 2015-07-10 13:37:45 UTC
You may have to wait for either John Ralls or Geert Janssens in that case as I'm not the build expert.  Both of whom are about to, or have just gone on holiday.
Comment 4 John Ralls 2015-07-10 19:55:31 UTC
Most of the time the only difference is that the files are compressed after the test. I've changed that in git so that they won't be; now they'll only change if scrub does. It will be in the next release.
Comment 5 Dmitry Smirnov 2015-07-10 22:28:58 UTC
Thanks. Those files are not just compressed but also have "<ts:date>" timestamp changed. Ideally it would be nice if those files are not changed at all or re-built from scratch every time.
I wanted to try your fix but could not find it in git...
I reckon I'll revisit this issue upon next release anyway...
Comment 6 John Ralls 2015-07-10 23:47:22 UTC
Oh, right, timezones.

They're not built files, but there's no good reason to write them back out, either. The intent is to make sure that the scrub functions work. I'll just comment out the save line.
Comment 7 John Ralls 2018-06-29 23:41:50 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=752204. Please update any external references or bookmarks.