After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752146 - osxvideosink: pipeline still doesn't want to stop on closing osxvideosink's window
osxvideosink: pipeline still doesn't want to stop on closing osxvideosink's w...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.5
Other Mac OS
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-08 22:14 UTC by Kyrylo V. Polezhaiev
Modified: 2018-11-03 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't need to be waiting for thread twice. (2.37 KB, patch)
2015-07-09 05:47 UTC, Justin Kim 		none Details | Review

Description Kyrylo V. Polezhaiev 2015-07-08 22:14:34 UTC 
Similar to this one (marked as fixed): https://bugzilla.gnome.org/show_bug.cgi?id=523134

Steps to reproduce:
1. gst-launch-1.0 videotestsrc ! osxvideosink
2. close osxvideosink's window

Expected behaviour:
Setting pipeline to NULL ...
Freeing pipeline ...

Actual behaviour:
Pipeline hangs.

Also: debugging this with Xcode makes Xcode freeze :)
Comment 1 Justin Kim 2015-07-09 05:07:50 UTC 
It seems to be related thread safety issue. When I tested with higher level of debug than 4, the pipeline can be terminated. but if less than 3, the pipeline was stuck.
Comment 2 Justin Kim 2015-07-09 05:47:46 UTC 
Created attachment 307129 [details] [review]
don't need to be waiting for thread twice.
Comment 3 Kyrylo V. Polezhaiev 2015-07-09 07:20:20 UTC 
I don't know if it helps, but I see no space character :-)
Comment 4 Justin Kim 2015-07-09 13:03:20 UTC 
> I don't know if it helps 
In my case, my patch works well. please check it.

> I see no space character
please, can you explain once again what you said? I don't understand :)
Comment 5 Kyrylo V. Polezhaiev 2015-10-12 23:56:25 UTC 
Oh, thats just about code style for line 750.
Comment 6 GStreamer system administrator 2018-11-03 15:01:59 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/201.