GNOME Bugzilla – Bug 75191
"Volume control" applet needs icons for different sizes
Last modified: 2004-12-22 21:47:04 UTC
"Volume control" applet icon should adjust size based on the size of the panel. This is important for accesibility for users with impaired vision.
this applet lives in gnome-applets, moving there
I think this could be easily fixed by just including a larger version of the icon in the build for scaling. (i can't quite remember but i think only one set of icons is provided right now so they don't scale)
Created attachment 10208 [details] [review] patch - resizes the applets icon based on the panel size
The above patch resizes the size of the icon whenever the size of the panel changes. It would be better to create a large pixbuf and scale that down. So that we get a nicer looking image. Calum would be adding the images here. CC'ing Calum. I think it would be enough to create larger versions of 5 xpm's. Adding keywords PATCH ... Is the patch o.k. ?
I've asked suzanna to re-do the icons at a larger size while she's doing the accessible versions of all the desktop icons... I'll attach them here when she's done them.
Patch applied with small changes to get the sizing just perfect :) Retitling to indicate the need for different size icons
*** Bug 87425 has been marked as a duplicate of this bug. ***
*** Bug 73828 has been marked as a duplicate of this bug. ***
Kevin: can this be committed to gnome-applets multihead branch ? [As it is quite significant from an accessibility point of view]
Deepa: yah, I'll attach the final patch, but you can just merge the changes from the stable branch also
Created attachment 10629 [details] [review] final patch - resize the icon
Hi Kevin: I am really sure what you wanted me to do :/. So i committed the final patch into "multihead" branch ;). Hope this is ok else we revert !
Yah, that's okay :)
Putting it into multihead only solves part of the problem, though- someone still has to merge it back from there to the mainline for 2.1.x. Is mark going to do that for all of the multihead branch or what?
Luis: no worries - it's been applied to all the branches now :)
Ok, so RC1 just went out, and no new icon. If this is not fixed in time for 2.0.2, I'd say the only option is to revert this patch because it is a MAJOR UI regression.
I'll ping suzanna on this again. I know she's done the accessible versions of the icon, but she still hasn't re-done the default ones at 48x48 AFAIK.
Created attachment 11041 [details] 48x48 icons for volume control applet, in PNG format
Updated with suzanna's new icons. The originals were XPMs, so I guess you can either convert them, or use gdk_pixbuf_from_file instead of gdk_pixbuf_from_xpm in the code.
I tried this attachment, but it gave me a bunch of errors when opening with an image viewer. Calum: could you try reattaching the image?
Oops, sorry-- didn't make it clear, but it's a tar file containing the images, not an image file...
Attaching a patch to size the icons and use the new ones. Awaiting release team approval
Created attachment 11053 [details] [review] Use new icons
Patch applied to both branches. Someone please thank Suzanna for the new icons. They look really nice :)
Very nice! Thanks a lot! :)