After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751884 - clicking on border crashes gnome-shell/mutter
clicking on border crashes gnome-shell/mutter
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 754025 756230 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-07-03 09:25 UTC by Marek Chalupa
Modified: 2015-10-08 06:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
handle META_FRAME_CONTROL_NONE (996 bytes, patch)
2015-07-03 09:30 UTC, Marek Chalupa 		none Details | Review
handle META_FRAME_CONTROL_NONE (1.17 KB, patch)
2015-07-10 06:35 UTC, Marek Chalupa 		committed Details | Review

Description Marek Chalupa 2015-07-03 09:25:30 UTC 
This happens under both wayland and X11. How to reproduce:

1) use theme clearlooks-phenix
2) start up firefox and maximize it
3) click on the left invisible "border"

The firefox window is resized over whole screen, but due to the theme it has 1px of transparent border on each side (except the top). Clicking onto this 1px makes mutter want to resize the window, but the window cannot be resized as it is maximized, so the operation is computed to be META_FRAME_CONTROL_NONE. But this value is not explicitly handled by switch, so it goes to abort() added in 85452af.
Comment 1 Marek Chalupa 2015-07-03 09:26:34 UTC 
Downstream bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1209008
Comment 2 Marek Chalupa 2015-07-03 09:30:42 UTC 
Created attachment 306688 [details] [review]
handle META_FRAME_CONTROL_NONE
Comment 3 Owen Taylor 2015-07-06 14:40:57 UTC 
Review of attachment 306688 [details] [review]:

The comment could be improved, otherwise seems fine to commit to me.

::: src/ui/frames.c
@@ +1056,3 @@
+    case META_FRAME_CONTROL_NONE:
+      /* We can get this for example when trying to resize window
+       * that cannot be resized (i. e. is maximized), see #751884 */

i.e. means "that is"
e.g. means "for example" and is what you meant here

Can you also mention the theme dependence

 (e.g., it is maximized and the theme has borders for maximized windows)
Comment 4 Marek Chalupa 2015-07-10 06:35:15 UTC 
Created attachment 307195 [details] [review]
handle META_FRAME_CONTROL_NONE
Comment 5 Jasper St. Pierre (not reading bugmail) 2015-07-10 17:09:41 UTC 
Review of attachment 307195 [details] [review]:

Looks good to me.
Comment 6 Michael Catanzaro 2015-07-14 21:13:04 UTC 
Marek, do you need someone to push this for you?
Comment 7 Marek Chalupa 2015-07-15 09:36:40 UTC 
yep, do not have permissions to do that
Comment 8 Michael Catanzaro 2015-07-15 12:47:18 UTC 
Comment on attachment 307195 [details] [review]
handle META_FRAME_CONTROL_NONE

OK, thanks!
Comment 9 Florian Müllner 2015-08-24 14:48:03 UTC 
*** Bug 754025 has been marked as a duplicate of this bug. ***
Comment 10 Florian Müllner 2015-10-08 06:23:51 UTC 
*** Bug 756230 has been marked as a duplicate of this bug. ***