After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751867 - omxvideodec: leak allocator after getting it from allocation query in RPi + GL case
omxvideodec: leak allocator after getting it from allocation query in RPi + G...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-02 22:49 UTC by Aurélien Zanelli
Modified: 2015-07-06 08:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
omxvideodec: unref allocator after getting it from allocation query (1.68 KB, patch)
2015-07-02 22:50 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2015-07-02 22:49:25 UTC
When target platform is RPi and with GL support enable, omxvideodec element leaks some allocator references when parsing allocation query in decide_allocation method.
Comment 1 Aurélien Zanelli 2015-07-02 22:50:27 UTC
Created attachment 306671 [details] [review]
omxvideodec: unref allocator after getting it from allocation query

Otherwise a reference will be leaked for each allocator. It only happens when target platform is Raspberry Pi and when we have GL support.
Comment 2 Sebastian Dröge (slomo) 2015-07-06 08:55:06 UTC
commit d2df0fb032c36b366a08a1355c4f4c816eb53447
Author: Aurélien Zanelli <aurelien.zanelli@darkosphere.fr>
Date:   Fri Jul 3 00:26:48 2015 +0200

    omxvideodec: unref allocator after getting it from allocation query
    
    Otherwise a reference will be leaked for each allocator. It only happens
    when target platform is Raspberry Pi and when we have GL support.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751867