Created attachment 306494 [details] [review]
Fix the return type of the index_entry_offset_search function.

Comment on attachment 306494 [details] [review]
Fix the return type of the index_entry_offset_search function.

Minor commit message / bug description comment:

>It should be modify from unsigned integer to integer type.

You mention *what* should be done, but please don't forget to add *why* something should be done (i.e. justify your claim / provide a rationale for the change).

commit 4f4605f4819c64ce557e25ef5987f463a49ee695
Author: Jimmy Ohn <yongjin.ohn@lge.com>
Date:   Wed Jul 1 21:46:46 2015 +0900

    avidemux: fix return type of index_entry_offset_search()
    
    It's a compare function and may return a negative value,
    so should for correctness and consistency return a signed
    integer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751780

(In reply to Tim-Philipp Müller from comment #2)
> Comment on attachment 306494 [details] [review] [review]
> Fix the return type of the index_entry_offset_search function.
> 
> Minor commit message / bug description comment:
> 
> >It should be modify from unsigned integer to integer type.
> 
> You mention *what* should be done, but please don't forget to add *why*
> something should be done (i.e. justify your claim / provide a rationale for
> the change).

Thanks for your review. I'll keep in mind for your comment.